search

tastytrade / tastytrade-api-js

Javascript sdk for the tastytrade api
MIT License
63 stars 34 forks source link

fix #19 target modern JS modules #30

Closed osdevisnot closed 4 months ago

osdevisnot commented 4 months ago

In addition to targeting modern js syntax code we should target modern JS modules too.

osdevisnot commented 4 months ago

@dmoss18 after this MR is merged, we should publish a new major version to NPM.

dmoss18 commented 4 months ago

@dmoss18 after this MR is merged, we should publish a new major version to NPM.

A major version means there would be breaking changes. Have we had any of those? I'd expect this to be a minor release.

osdevisnot commented 4 months ago

@dmoss18 after this MR is merged, we should publish a new major version to NPM.

A major version means there would be breaking changes. Have we had any of those? I'd expect this to be a minor release.

I would assume a change in the distribution format cjs -> esm as a major change.