tastytrade / tastytrade-api-js

Javascript sdk for the tastytrade api
MIT License
63 stars 34 forks source link

fix #33: setup builds for pull requests #34

Closed osdevisnot closed 4 months ago

osdevisnot commented 4 months ago

This PR enables build and unit-test for pull requests; see the successfully passing checks below.

osdevisnot commented 4 months ago

@dmoss18 I think we should also run integration tests as a part of every PR as well. The steps to enable that would be:

More information here: https://docs.github.com/en/actions/learn-github-actions/variables#defining-environment-variables-for-a-single-workflow

Of course this PR doesn't cover that and I can't even create a PR for this since it needs github admin permissions.

Open to feedback on this topic.

dmoss18 commented 4 months ago

We've thought about this in the past and I think instead of running the integration tests, we should build out the unit tests with mocked out http responses. The reason is we don't want CI to be making external http requests. We will move those tests into the unit tests folder eventually.

osdevisnot commented 4 months ago

That's fair; I will spend some time on porting some of the tests to unit tests with mocked responses in subsequent MRs.