tastyware / tastytrade

An unofficial, sync/async Python SDK for Tastytrade!
https://tastyworks-api.rtfd.io
MIT License
126 stars 43 forks source link

MarginReportEntry bug fix #145

Closed Quenos closed 6 months ago

Quenos commented 6 months ago

Description

Account.MarginEntryReport changed to also handle options on futures correctly. Some fields were made Optional

Related issue(s)

Fixes #144

Pre-merge checklist

Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.

Graeme22 commented 6 months ago

Thanks @Quenos !

Quenos commented 6 months ago

Sure thing! BTW: I don’t know if you’ve seen it but the advanced-streamer branch is also available.

-- Best regards, Coen Kuijpers Automotive Functional Safety Expert Tel: +31 6 4463 1722 (The Netherlands) +36 70 789 3142 (Hungary)

[signature_157047780]

From: Graeme Holliday @.> Date: Sunday, May 12, 2024 at 6:29 PM To: tastyware/tastytrade @.> Cc: Coen Kuijpers @.>, Mention @.> Subject: Re: [tastyware/tastytrade] MarginReportEntry bug fix (PR #145)

Thanks @Quenoshttps://github.com/Quenos !

— Reply to this email directly, view it on GitHubhttps://github.com/tastyware/tastytrade/pull/145#issuecomment-2106307373, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIKO67IQTF35LYAJQZPJHELZB6KHHAVCNFSM6AAAAABHR3RGW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGMYDOMZXGM. You are receiving this because you were mentioned.Message ID: @.***>