isSchoolHolidays - Issue with year selection ?

[francois-le-ko4la]

NR Version: 3.1.3 Node Info: Version: 1.1.7 - Updated 1 month ago

Hi,

Honnestly thanks a lot for this pluggin ! Today I saw an issue with the plugin that help me to manage my covers. ^^ isSchoolHolidays return a bad value and thats seems to be an issue with Year selection.

I get on debug mode :

02/01/2024 12:51:43[noeud: debug 7](https://XXXX:1880/#)
topic1 : msg.payload : Object

{
   "day":2,
   "isPublicHoliday":false,
   "isTomorrowPublicHoliday":false,
   "publicHolidayName":null,
   "nextPublicHolidayName":"Lundi de Pâques",
   "nextPublicHolidayDate":"01/04/2024",
   "isSchoolHolidays":false,
   "isTomorrowSchoolHolidays":false,
   "schoolHolidaysName":null,
   "nextSchoolHolidaysCoutdownInDays":290,
   "nextSchoolHolidaysName":"Vacances de la Toussaint",
   "nextSchoolHolidaysStartDate":"19/10/2024",
   "nextSchoolHolidaysEndDate":"04/11/2024",
   "year":2024
}

When I take a look on my rednode console I get :

current>>>2024
nextYear>>>2025
2 Jan 12:51:41 - [info] [mqtt-broker:MQTT] Connected to broker: ws://172.21.0.3:8083/mqtt
2 Jan 12:51:41 - [info] [server:HomeAssistant] Connected to https://192.168.1.250:8123
nhits=7 parameters={"dataset":"fr-en-calendrier-scolaire","rows":100,"start":0,"facet":["description","start_date","end_date","location","zones"],"refine":{"annee_scolaire":"2024-2025"},"format":"json","timezone":"UTC"} records=[{"datasetid":"fr-en-calendrier-scolaire","recordid":"352b8d70aaec0f03aaef8960fe81731a81174467","fields":{"end_date":"2025-05-30T22:00:00+00:00","start_date":"2025-05-29T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Pont de l'Ascension","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"573dd2c2481e199111c18c1df5c3d32ee557b086","fields":{"end_date":"2025-01-05T23:00:00+00:00","start_date":"2024-12-20T23:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances de Noël","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"e03ccfcd7d15ce712d6e4c2e1367fe5303f71d66","fields":{"end_date":"2025-04-27T22:00:00+00:00","start_date":"2025-04-11T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances de Printemps","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"e75c2723d67e2446b92ce732326518b3293d2730","fields":{"end_date":"2024-11-03T23:00:00+00:00","start_date":"2024-10-18T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances de la Toussaint","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"bdb00dd42516a971b80b969b4fe0b99f2266a2eb","fields":{"end_date":"2025-03-02T23:00:00+00:00","start_date":"2025-02-14T23:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances d'Hiver","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"12777440bb56e63addee9fa6bcf2fef7aa5211a1","fields":{"end_date":"2025-08-31T22:00:00+00:00","start_date":"2025-07-04T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances d'Été","zones":"Zone C","population":"Élèves"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"a3e1db6d029597225f5545ee2e4f03e7ccbd9b5b","fields":{"end_date":"2025-08-28T22:00:00+00:00","start_date":"2025-07-04T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances d'Été","zones":"Zone C","population":"Enseignants"},"record_timestamp":"2023-10-10T14:00:14.676Z"}] facet_groups=[{"name":"description","facets":[{"name":"Vacances d'Été","count":2,"state":"displayed","path":"Vacances d'Été"},{"name":"Pont de l'Ascension","count":1,"state":"displayed","path":"Pont de l'Ascension"},{"name":"Vacances d'Hiver","count":1,"state":"displayed","path":"Vacances d'Hiver"},{"name":"Vacances de Noël","count":1,"state":"displayed","path":"Vacances de Noël"},{"name":"Vacances de Printemps","count":1,"state":"displayed","path":"Vacances de Printemps"},{"name":"Vacances de la Toussaint","count":1,"state":"displayed","path":"Vacances de la Toussaint"}]},{"name":"start_date","facets":[{"name":"2024","count":2,"state":"displayed","path":"2024"},{"name":"2025","count":5,"state":"displayed","path":"2025"}]},{"name":"end_date","facets":[{"name":"2024","count":1,"state":"displayed","path":"2024"},{"name":"2025","count":6,"state":"displayed","path":"2025"}]},{"name":"location","facets":[{"name":"Paris","count":7,"state":"refined","path":"Paris"}]},{"name":"zones","facets":[{"name":"Zone C","count":7,"state":"displayed","path":"Zone C"}]},{"name":"annee_scolaire","facets":[{"name":"2024-2025","count":7,"state":"refined","path":"2024-2025"}]}] 

daysDifference: 290
holiday  : Vacances de la Toussaint
current>>>2024
nextYear>>>2025
nhits=7 parameters={"dataset":"fr-en-calendrier-scolaire","rows":100,"start":0,"facet":["description","start_date","end_date","location","zones"],"refine":{"annee_scolaire":"2024-2025"},"format":"json","timezone":"UTC"} records=[{"datasetid":"fr-en-calendrier-scolaire","recordid":"352b8d70aaec0f03aaef8960fe81731a81174467","fields":{"end_date":"2025-05-30T22:00:00+00:00","start_date":"2025-05-29T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Pont de l'Ascension","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"573dd2c2481e199111c18c1df5c3d32ee557b086","fields":{"end_date":"2025-01-05T23:00:00+00:00","start_date":"2024-12-20T23:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances de Noël","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"e03ccfcd7d15ce712d6e4c2e1367fe5303f71d66","fields":{"end_date":"2025-04-27T22:00:00+00:00","start_date":"2025-04-11T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances de Printemps","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"e75c2723d67e2446b92ce732326518b3293d2730","fields":{"end_date":"2024-11-03T23:00:00+00:00","start_date":"2024-10-18T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances de la Toussaint","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"bdb00dd42516a971b80b969b4fe0b99f2266a2eb","fields":{"end_date":"2025-03-02T23:00:00+00:00","start_date":"2025-02-14T23:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances d'Hiver","zones":"Zone C","population":"-"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"12777440bb56e63addee9fa6bcf2fef7aa5211a1","fields":{"end_date":"2025-08-31T22:00:00+00:00","start_date":"2025-07-04T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances d'Été","zones":"Zone C","population":"Élèves"},"record_timestamp":"2023-10-10T14:00:14.676Z"},{"datasetid":"fr-en-calendrier-scolaire","recordid":"a3e1db6d029597225f5545ee2e4f03e7ccbd9b5b","fields":{"end_date":"2025-08-28T22:00:00+00:00","start_date":"2025-07-04T22:00:00+00:00","location":"Paris","annee_scolaire":"2024-2025","description":"Vacances d'Été","zones":"Zone C","population":"Enseignants"},"record_timestamp":"2023-10-10T14:00:14.676Z"}] facet_groups=[{"name":"description","facets":[{"name":"Vacances d'Été","count":2,"state":"displayed","path":"Vacances d'Été"},{"name":"Pont de l'Ascension","count":1,"state":"displayed","path":"Pont de l'Ascension"},{"name":"Vacances d'Hiver","count":1,"state":"displayed","path":"Vacances d'Hiver"},{"name":"Vacances de Noël","count":1,"state":"displayed","path":"Vacances de Noël"},{"name":"Vacances de Printemps","count":1,"state":"displayed","path":"Vacances de Printemps"},{"name":"Vacances de la Toussaint","count":1,"state":"displayed","path":"Vacances de la Toussaint"}]},{"name":"start_date","facets":[{"name":"2024","count":2,"state":"displayed","path":"2024"},{"name":"2025","count":5,"state":"displayed","path":"2025"}]},{"name":"end_date","facets":[{"name":"2024","count":1,"state":"displayed","path":"2024"},{"name":"2025","count":6,"state":"displayed","path":"2025"}]},{"name":"location","facets":[{"name":"Paris","count":7,"state":"refined","path":"Paris"}]},{"name":"zones","facets":[{"name":"Zone C","count":7,"state":"displayed","path":"Zone C"}]},{"name":"annee_scolaire","facets":[{"name":"2024-2025","count":7,"state":"refined","path":"2024-2025"}]}] 

daysDifference: 290
holiday  : Vacances de la Toussaint

[francois-le-ko4la]

Arf! I see the issue. In your code, when you are in 2/1/2024 it will take the 2024/2025 period because you take the current year...

  var currentYear = today.getFullYear()
  ...
  var schoolHolidaysApi =
    'https://data.education.gouv.fr/api/records/1.0/search/?dataset=fr-en-calendrier-scolaire&q=&rows=100&facet=description&facet=start_date&facet=end_date&facet=zones&facet=annee_scolaire&refine.start_date='+currentYear+'&refine.location='+this.academy
  var entireSchoolHolidaysCalendarApi = 
  'https://data.education.gouv.fr/api/records/1.0/search/?dataset=fr-en-calendrier-scolaire&q=&rows=100&facet=description&facet=start_date&facet=end_date&facet=location&facet=zones&refine.location='+this.academy+'&refine.annee_scolaire='+currentYear+'-'+nextYear

[tataille]

@francois-le-ko4la , please check with new version 1.1.8 and let me know in the comments. I will close issue.

[MaelFr]

Hello, Fixes the issue on my side. Thanks for this plugin.

[tataille]

User confirmed the fix