search

tataille / node-red-french-holidays

A node-red component for French Holiday
Apache License 2.0
7 stars 2 forks source link

Le nœud ne renvoi pas les vacances scolaires en cours. #16

Closed replayfactory closed 1 month ago

replayfactory commented 1 month ago

Nous sommes dans les vacances de Toussaint (Montpellier / Zone C), le Lundi 21 octobre mais les données renvoyées ne correspondent pas :

{
   "day":1,
   "isPublicHoliday":false,
   "isTomorrowPublicHoliday":false,
   "publicHolidayName":null,
   "nextPublicHolidayName":"Toussaint",
   "nextPublicHolidayDate":"01/11/2024",
   "isSchoolHolidays":false,
   "isTomorrowSchoolHolidays":false,
   "schoolHolidaysName":null,
   "schoolHolidaysEndDate":null,
   "nextSchoolHolidaysCoutdownInDays":60,
   "nextSchoolHolidaysName":"Vacances de Noël",
   "nextSchoolHolidaysStartDate":"21/12/2024",
   "nextSchoolHolidaysEndDate":"06/01/2025",
   "schoolPeriod":"2024-2025",
   "year":2024,
   "region":"Métropole",
   "academy":"Montpellier",
   "zones":"Zone C",
   "version":"1.2.3"
}
2lastelle commented 1 month ago

Idem Zone A

object day: 1 isPublicHoliday: false isTomorrowPublicHoliday: false publicHolidayName: null nextPublicHolidayName: "Toussaint" nextPublicHolidayDate: "01/11/2024" isSchoolHolidays: false isTomorrowSchoolHolidays: false schoolHolidaysName: null schoolHolidaysEndDate: null nextSchoolHolidaysCoutdownInDays: 60 nextSchoolHolidaysName: "Vacances de Noël" nextSchoolHolidaysStartDate: "21/12/2024" nextSchoolHolidaysEndDate: "06/01/2025" schoolPeriod: "2024-2025" year: 2024 region: "Métropole" academy: "Grenoble" zones: "Zone A" version: "1.2.2"

CTPA commented 1 month ago

Bonjour, j'ai le même problème aussi en zone C, Paris

{"day":1,"isPublicHoliday":false,"isTomorrowPublicHoliday":false,"publicHolidayName":null,"nextPublicHolidayName":"Toussaint","nextPublicHolidayDate":"01/11/2024","isSchoolHolidays":false,"isTomorrowSchoolHolidays":false,"schoolHolidaysName":null,"schoolHolidaysEndDate":null,"nextSchoolHolidaysCoutdownInDays":60,"nextSchoolHolidaysName":"Vacances de Noël","nextSchoolHolidaysStartDate":"21/12/2024","nextSchoolHolidaysEndDate":"06/01/2025","schoolPeriod":"2024-2025","year":2024,"region":"Métropole","academy":"Paris","zones":"Zone C","version":"1.2.3"}

tataille commented 1 month ago

Problem identifed. Fix is in progress.

fdecourt commented 1 month ago

Je me disais bien que tous mes automatisme basés sur sur noeud étaient lancés alors qu'ils ne devraient pas. Merci @tataille pour le futur correctif

CTPA commented 1 month ago

Oui, ici aussi, j'ai le réveil de mes enfants qui utilise ce nœud, c'est mes filles qui ont fait la tête ce matin :-) MERCI! BiG

tataille commented 1 month ago

Problem fixed in version 1.2.4. Please update the plugin version is node-red palette manager.

tataille commented 1 month ago

Example for Paris (Zone C) with vefrsion 1.2.4

{ "day":1, "isPublicHoliday":false, "isTomorrowPublicHoliday":false, "publicHolidayName":null, "nextPublicHolidayName":"Toussaint", "nextPublicHolidayDate":"01/11/2024", "isSchoolHolidays":true, "isTomorrowSchoolHolidays":true, "schoolHolidaysName":"Vacances de la Toussaint", "schoolHolidaysEndDate":"04/11/2024", "nextSchoolHolidaysCoutdownInDays":60, "nextSchoolHolidaysName":"Vacances de Noël", "nextSchoolHolidaysStartDate":"21/12/2024", "nextSchoolHolidaysEndDate":"06/01/2025", "schoolPeriod":"2024-2025", "year":2024, "region":"Métropole", "academy":"Paris", "zones":"Zone C", "version":"1.2.4" }