search

tataratat / gustaf

python library to process and visualize numerical-analysis-geometries
https://tataratat.github.io/gustaf
Other
16 stars 8 forks source link

Ft: remove splinepy ipynb example #192

Closed clemens-fricke closed 5 months ago

clemens-fricke commented 7 months ago

I was not sure if we should remove the splinepy example from the gustaf ipynb example.

Pro (keep it): Better visibility of splinepy from another package

Con (remove it): Additional dependency people have to install to run the example Example of something that is not even part of the package itself

I am personally ok with keeping it in, but wanted to give you all the option to weigh in with your opinions.

jzwar commented 7 months ago

I am very conflicted given your branch name and pr title suggest opposite things :D

I tend towards removing it. We should maybe consider finally starting a separate repository with more animations and examples, that would give us a little more freedom when it comes to additional dependencies. So many example files are forgotten too quickly which is unfortunate.

j042 commented 7 months ago

I am okay with keeping it