Closed mkofler96 closed 11 months ago
First it was called DrilledCrossTile1D, but Jacques suggested to give it another name:
The name of the file should be in snake_case
, please. Also, consider naming the tile
DrilledCrossBeams
or TwistedCrossBeams
to avoid confusion...
Originally posted by @jzwar in https://github.com/tataratat/splinepy/issues/294#issuecomment-1810012860
@
First it was called DrilledCrossTile1D, but Jacques suggested to give it another name:
The name of the file should be in
snake_case
, please. Also, consider naming the tileDrilledCrossBeams
orTwistedCrossBeams
to avoid confusion...Originally posted by @jzwar in #294 (comment)
so, Cross1D
? @jzwar
I don't want the dimensionality to be part of the tile's name. This is why I added the para_dim and dim properties to the tiles. If you feel like this is insufficient, we can change the directory structure to
tiles.
├── 1D
│ └── drilled_beam.py
├── 2D
│ └── cross_2d.py
│ └── ...
└── 3D
└── ...
└── ...
though I personally feel like this is unnecessary... We can add a module function show_available_tiles
or something similar
@jzwar don't we already have Cross2D
/Cross3D
? However, I guess this is X
. What about X
?
as X
is not recommended class name, let's go with Chi
Overview
added new microtile
Addressed issues
.
Showcase
A "short" example to highlight the (new) feature
Checklists