search

tataratat / splinepy

Library for prototyping spline geometries of arbitrary dimensions and degrees, and IGA
https://tataratat.github.io/splinepy
Other
47 stars 13 forks source link

Bugfix - Wrong indices for back substitution #386

Closed jzwar closed 7 months ago

jzwar commented 8 months ago

The indices of the solution vector do not change as the pivoting only affects the rows of the matrix and the lhs, but not the solution (columns remain unchanged).

@j042, please verify

Addressed issues

Checklists

jzwar commented 8 months ago

Also : I would like to delete the unused function: GaussWithPivot to avoid confusion

j042 commented 7 months ago

What a good catch, thanks! I agree with some clean up. Maybe we can add LAPACK based solve for debug or maybe use that as numpy always comes with lapack/blas

j042 commented 7 months ago

What a good catch, thanks! I agree with some clean up. Maybe we can add LAPACK based solve for debug or maybe use that as numpy always comes with lapack/blas

I can clean up

jzwar commented 7 months ago

What a good catch, thanks! I agree with some clean up. Maybe we can add LAPACK based solve for debug or maybe use that as numpy always comes with lapack/blas

@j042 If it is ok with you, I would just write an issue to push this to later. Imo, we can already merge this pr and wait with both clean up and bugfix for convergence issues for later...

j042 commented 7 months ago

Sure