tataratat / splinepy

Library for prototyping spline geometries of arbitrary dimensions and degrees, and IGA
https://tataratat.github.io/splinepy
Other
47 stars 13 forks source link

Enforce Recomputation of Multipatch Interfaces #388

Closed jzwar closed 7 months ago

jzwar commented 7 months ago

Overview

As the title says.

Checklists

j042 commented 7 months ago

When was this causing err?

jzwar commented 7 months ago

When was this causing err?

No error, but also no way to recompute once done. This just adds a new option.

j042 commented 7 months ago

When was this causing err?

No error, but also no way to recompute once done. This just adds a new option.

I think I've mentioned this back then: what about removing property/setter and use "vedo style":

mp.interface(new_inter)  # setter
interf = mp.interface()  # getter
recomp_interf = mp.interface(recompute=False) # getter
jzwar commented 7 months ago

When was this causing err?

No error, but also no way to recompute once done. This just adds a new option.

I think I've mentioned this back then: what about removing property/setter and use "vedo style":

mp.interface(new_inter)  # setter
interf = mp.interface()  # getter
recomp_interf = mp.interface(recompute=False) # getter

Naaaaa, I like the properties. In 99% of cases, you need no recomputation

j042 commented 7 months ago

When was this causing err?

No error, but also no way to recompute once done. This just adds a new option.

I think I've mentioned this back then: what about removing property/setter and use "vedo style":

mp.interface(new_inter)  # setter
interf = mp.interface()  # getter
recomp_interf = mp.interface(recompute=False) # getter

Naaaaa, I like the properties. In 99% of cases, you need no recomputation

1% is what matters

jzwar commented 7 months ago

When was this causing err?

No error, but also no way to recompute once done. This just adds a new option.

I think I've mentioned this back then: what about removing property/setter and use "vedo style":

mp.interface(new_inter)  # setter
interf = mp.interface()  # getter
recomp_interf = mp.interface(recompute=False) # getter

Naaaaa, I like the properties. In 99% of cases, you need no recomputation

1% is what matters

Let's not get political 😄 I like the properties

jzwar commented 7 months ago

Can we go with setter and getter for cpp? I don't like that you have to give empty list to give a recompute flag (interfaces = super().interfaces([], recompute))

PyMultipatch::SetInterface(py::array_t<double>);

PyMultipatch::GetInterface(bool recompute);

done