xml io issues for CATS splines

[felipegonzalezco]

I found the following problems when generating a spline for CATS SplineLib:

1. the keyword closed expects at least splDim entries
2. we use kntVec instead of knotVec for each individual knot vector
3. weights are not optional and must be present

[jzwar]

@felipegonzalezco Would it be possible to quickly post a minimal example of the current state and how it should be fixed, to better understand what is the issue, please? That would be very helpful.

[felipegonzalezco]

Sure. As examples, here are screenshots of each case. First, the keyword closed expects splDim entries. Currently, splinepy is writing only one value.

Second, kntVec is used for individual knot vectors. It's kinda consistent with kntVecs which is the vector of knot vectors.

And third, I get an error if weights are not defined:

I hope it is more clear now.

[jzwar]

Just to make sure, for the second we need to rename knotVec to kntVec?

[jzwar]

For the third, are weights only exported for rational splines or do they need to be exported for non-rational splines as well.

[jzwar]

I updated the code to deal with the first two issues, please check out the branch bf-433

[j042]

After looking through the sources of cats-splinelib, it seems that the static buffer - that fortran splinelib creates for xml.io - is too small to load a "long" line or expects less value per line. Not conclusive yet

[jzwar]

@felipegonzalezco did you try it out?

[j042]

fixed in #436 and #433. will be available in v0.1.1

[felipegonzalezco]

Sorry for the late reply. I tried it out and it worked, so the issues are resolved. Thank you for fixing them.