Closed jzwar closed 2 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The updates enhance the spline export and import routines in splinepy/io/cats.py
. Key changes include renaming "knotVec" to "kntVec", refining the logic for periodicity checks, and introducing a make_rational
parameter in the export
function to toggle between NURBS and B-splines. Accompanying tests in tests/io/test_cats.py
reflect these changes and ensure compatibility with the new export logic.
File(s) | Change Summary |
---|---|
splinepy/io/cats.py |
Updated "knot_vector" key, revised periodicity check, added make_rational parameter to export function. |
tests/io/test_cats.py |
Adjusted XML closed and kntVec , added test for splines rational export option. |
Objective (Issue #) | Addressed | Explanation |
---|---|---|
Ensure closed keyword has at least splDim entries (#433) |
✅ | |
Use kntVec instead of knotVec for knot vectors (#433) |
✅ | |
Make weights mandatory (#433) |
✅ |
In the world of splines we twine, With vectors marked as
kntVec
, Rational splines, easy to find, In CATS' library, no more tech wreck! Code refined and tests aligned, A rabbit's joy, oh what the heck! 🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Fixes #433
Please @j042 check if this interrupts your workflow
Checklists
Summary by CodeRabbit
New Features
make_rational
to the export functionality, allowing users to choose betweennurbs
andbspline
.Bug Fixes
<knotVec>
to<kntVec>
.Tests
make_rational
parameter.