Closed j042 closed 2 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The function spline
in splinepy/helpme/extract.py
has been enhanced to better handle split planes by accommodating tuples, lists, and NumPy arrays. The updated logic more rigorously checks the validity of these input types, ensuring they are either floats or two-element sequences of floats. The checks for NumPy arrays now include validation of dtype and size constraints, improving the robustness and flexibility of the function.
File | Change Summary |
---|---|
splinepy/helpme/extract.py |
Enhanced spline function to handle split planes as tuples, lists, or NumPy arrays, with improved validation checks. |
Amidst the code where splines align,
A rabbit's touch makes functions shine.
With tuples, lists, and arrays so wise,
Precision in the data flies.
NumPy checks all set in place,
For robust code, we'll always chase.
🌟 Hooray for changes, smart and neat,
The spline's new tune is now complete! 🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Overview
splinepy.helpme.extract.spline
checks input type against list and float. however, often in applications, we have other iterables. This PR allows other frequently used iterables and floating types of numpy.Addressed issues
Checklists
Summary by CodeRabbit
spline
function to support tuples, lists, or NumPy arrays, ensuring compatibility with different data types and structures.