Closed j042 closed 3 months ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The recent updates enhance the NURBS spline handling in the splinepy/io/mfem.py
module, specifically by improving the loading and exporting functionalities. The changes ensure accurate knot vector processing, better validation, and support for multiple dimensions, particularly addressing 3D cases. Additionally, a new test function test_mfem_single_patch_export
has been introduced to validate these functionalities.
File / Module | Change Summary |
---|---|
splinepy/io/mfem.py |
Updated load and export functions: enhanced knot vector handling, added 3D support, validation logic improvements. |
tests/io/test_mfem_export.py |
Added test_mfem_single_patch_export to validate MFEM single patch export. |
sequenceDiagram
participant User
participant SplineLoader
participant SplineExporter
Note over User, SplineLoader: Loading a spline
User->>SplineLoader: Call load function
SplineLoader->>SplineLoader: Initialize degrees, ncps, knot_vectors
SplineLoader->>SplineLoader: Populate knot_vectors using loop
SplineLoader->>SplineLoader: Validate spline information
SplineLoader-->>User: Return loaded spline
Note over User, SplineExporter: Exporting a spline
User->>SplineExporter: Call export function
SplineExporter->>SplineExporter: Check for mixed orders
SplineExporter->>SplineExporter: Handle 3D section (elements, boundaries, etc.)
SplineExporter->>SplineExporter: Format knot vectors using kv_sec
SplineExporter-->>User: Return exported spline
In code we weave the spline's delight,
With knot and point, dimensions bright.
Through 3D space our paths entwine,
Export, import - the process shines.
Celebrate the patch, a single quest,
For NURBS now perform their best!
🌟✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Overview
Extends single-patch IO to 3D
Addressed issues
Next
For complex multipatches, either revive
edges
or contribute to MFEMChecklists
Summary by CodeRabbit
New Features
Tests