has the edit post option moved or been removed?

[pswilde]

Hi, I was just wondering if "Edit" has been moved from "your toot" or removed from the app completely? I just can't see it any more. I noticed it vanished when updating from 504 to 507 of Subway Tooter. Currently on 5.511 and it still isn't there (though I can see "Edit History").

Thanks for the app though, I love it!

[tateisu]

can you see pencil icon in 「…」more menu for each post?

2023年2月7日(火) 18:41 Paul Wilde @.***>:

Hi, I was just wondering if "Edit" has been moved from "your toot" or removed from the app completely? I just can't see it any more. I noticed it vanished when updating from 504 to 507 of Subway Tooter. Currently on 5.511 and it still isn't there (though I can see "Edit History").

Thanks for the app though, I love it!

— Reply to this email directly, view it on GitHub https://github.com/tateisu/SubwayTooter/issues/226, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRQ6GJI5UX6NUSE3WOTULWWIKDBANCNFSM6AAAAAAUTXGHQ4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[pswilde]

Hi, No, I do not. I only see the following:
Under "Your Toot" I only see "delete and redraft", "pin on profile" and "delete" I should say I am using Pleroma, not Mastodon, which is likely where this problem is cropping up. It worked fine on version 504 and previous though so I know the functionality should work - just the option is missing.

[tateisu]

this is condition that button is shown.

val canEdit = statusByMe && (TootInstance.getCached(column.accessInfo) ?.let { it.isMastodon && it.versionGE(TootInstance.VERSION_3_5_0_rc1) } ?: false)

val statusByMe = accessInfo.isMe(status.account)

val isMastodon get() = instanceType == InstanceType.Mastodon

enum class InstanceType { Mastodon, Misskey, Pixelfed, Pleroma }

2023年2月7日(火) 21:04 Paul Wilde @.***>:

Hi, No, I do not. I only see the following:

Under "Your Toot" I only see "delete and redraft", "pin on profile" and "delete" I should say I am using Pleroma, not Mastodon, which is likely where this problem is cropping up. It worked fine on version 504 and previous though so I know the functionality should work - just the option is missing.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

[pswilde]

I see, OK thanks. Looks like it's only allowing editing on Mastodon v3.5.0rc1 and above. That makes sense. OK, if I get time I'll see if I can make it work without affecting things too much and submit a pull request. Thanks for your help

[tateisu]

I'm saved. To be honest, I don't really understand Pleroma's versioning in api/v1/instance.

2023年2月7日(火) 21:18 Paul Wilde @.***>:

I see, OK thanks. Looks like it's only allowing editing on Mastodon v3.5.0rc1 and above. That makes sense. OK, if I get time I'll see if I can make it work without affecting things too much and submit a pull request. Thanks for your help

— Reply to this email directly, view it on GitHub https://github.com/tateisu/SubwayTooter/issues/226#issuecomment-1420681491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRQ6DPTR6LPLO2I24ZGYTWWI4PXANCNFSM6AAAAAAUTXGHQ4 . You are receiving this because you commented.Message ID: @.***>

[pswilde]

I agree. The versioning in Pleroma is not good - even worse if you think about Akkoma and Rebased too. However It does have in /api/v1/instance a pleroma: metadata: features node with one available string item being "editing" so it's probably worth checking that as an option to enable editing.

[tateisu]

The feature list is one thing Mastodon lacks. I knew Fedibird kept a list of additional features, but I didn't know Preloma had it too.

2023年2月7日(火) 21:39 Paul Wilde @.***>:

I agree. The versioning in Pleroma is not good - even worse if you think about Akkoma and Rebased too. However It does have in /api/v1/instance a pleroma: metadata: features node with one available string item being "editing" so it's probably worth checking that as an option to enable editing.

— Reply to this email directly, view it on GitHub https://github.com/tateisu/SubwayTooter/issues/226#issuecomment-1420706505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRQ6A7TEN6NZ5GECW53WLWWI66XANCNFSM6AAAAAAUTXGHQ4 . You are receiving this because you commented.Message ID: @.***>

[tateisu]

8a6ad18ba7ce4d8363dfe280922404adfb7cceec changed, but not tested.

[pswilde]

Looks good! I'd be happy to test this, though for some reason I'm unable to compile SubwayTooter myself (I dont really do app development, I probably have a configuration error somewhere). if this is in the next pre-release then I'll report back whether it works or not

[tateisu]

check github release page, that is already included.

2023年2月11日(土) 3:48 Paul Wilde @.***>:

Looks good! I'd be happy to test this, though for some reason I'm unable to compile SubwayTooter myself (I dont really do app development, I probably have a configuration error somewhere). if this is in the next pre-release then I'll report back whether it works or not

— Reply to this email directly, view it on GitHub https://github.com/tateisu/SubwayTooter/issues/226#issuecomment-1426202478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACRQ6FISOCC7JFMSBAXLDDWW2EOPANCNFSM6AAAAAAUTXGHQ4 . You are receiving this because you commented.Message ID: @.***>

[pswilde]

oh yes, i see now, i needed to look at the tags list. yep, v5.514 is working perfectly. thank you!

[tateisu]

thanks!