search

tatethurston / TwirpScript

A protobuf RPC framework for JavaScript and TypeScript
MIT License
141 stars 14 forks source link

Fix optional message default value #165

Closed tatethurston closed 2 years ago

tatethurston commented 2 years ago

Optional messages now default to undefined. Fixes #162.

codecov-commenter commented 2 years ago

Codecov Report

Merging #165 (1d416aa) into main (935a03e) will decrease coverage by 0.23%. The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   86.15%   85.91%   -0.24%     
==========================================
  Files          14       14              
  Lines        1416     1463      +47     
  Branches      437      453      +16     
==========================================
+ Hits         1220     1257      +37     
- Misses        196      206      +10
Impacted Files Coverage Δ
src/test-serialization/message.pb.ts 87.35% <77.27%> (-1.15%) :arrow_down:
src/autogenerate/index.ts 97.17% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 935a03e...1d416aa. Read the comment docs.