tatjam / tatjam.github.io

A extremely simple C++ site-generator adapted for my development blog
2 stars 1 forks source link

Issue with Label Generator Hazard Icons #1

Open jd6754 opened 1 year ago

jd6754 commented 1 year ago

Hi there. I love your label generator (I just shared the link with a bunch of colleagues at the University of Sydney where I work), but found today that when I try to generator a new label every single GHS hazard symbol shows up (see image below). Any chance of having a look to see what's going on?

image

Thanks heaps,

JD

tatjam commented 1 year ago

Hey! I have reproduced the issue, and it seems to be due to slow scraping of the pubchem website. I will try to improve a bit the GHS scraper as it seems to be very conservative (ie, it includes every single GHS symbol mentioned, which usually leads to a lot more symbols than required) and slow.

It seems to fix itself after a little while, but if the error persists you can try either reloading the page or hitting "enter" a few times while the molecule name / SMILES / CID is selected. If nothing works, you can manually change the GHS symbols:

imagen

tatjam commented 1 year ago

(Note to self: Hitting enter works because it forces a reload of the pubchem data)

jd6754 commented 1 year ago

Fantastic, thanks so much! And congrats again on making such an excellent and needed tool :)