search

tatsuhiro-t / spdylay

The experimental SPDY protocol version 2, 3 and 3.1 implementation in C
http://tatsuhiro-t.github.io/spdylay/
MIT License
603 stars 102 forks source link

[shrpx] fix password handling for certs keys #39

Closed rgs1 closed 11 years ago

rgs1 commented 11 years ago

We should only call daemon() after ListenHandler is instantiated, where SSL_CTX_use_PrivateKey_file is called, otherwise we have no stdin/stdout to get the password for keyfile.

tatsuhiro-t commented 11 years ago

It seems that same patch was merged in https://github.com/tatsuhiro-t/spdylay/pull/38 though commit id is not the same. Can we close now?

rgs1 commented 11 years ago

On 27 October 2012 23:55, Tatsuhiro Tsujikawa notifications@github.comwrote:

It seems same patch was merged in tatsuhiro-t/spdylay#38https://github.com/tatsuhiro-t/spdylay/issues/38though commit id is not the same. Can we close now?

Yeah - accidentally pushed to both branches. We can close.

—

Reply to this email directly or view it on GitHubhttps://github.com/tatsuhiro-t/spdylay/pull/39#issuecomment-9843250.

tatsuhiro-t commented 11 years ago

OK, let's close. Thank you.