search

tatsuhiro-t / spdylay

The experimental SPDY protocol version 2, 3 and 3.1 implementation in C
http://tatsuhiro-t.github.io/spdylay/
MIT License
603 stars 102 forks source link

Ensure the stream data is available in the on_stream_close callback #7

Closed sorced-jim closed 12 years ago

sorced-jim commented 12 years ago

The documentation says FLAG_FIN should be ignored for on_data_chunk_recv_callback, so I tried to print a response in either on_stream_close_callback or on_data_recv_callback, but by the time the later two were called the user stream data was already erased.

tatsuhiro-t commented 12 years ago

Thank you. I merged on_stream_close callback bug fix. For pkg-config thing, I added cunit and openssl check in configure.ac and substitute variable _LIBS and _CLFAGS in {tests/examples}/Makefile.am.

I think we can get rid of -lncurses in tests/Makefile.am. CUnit can be built without it and we don't use curses interface. If you agree, I'll remove it from tests/Makefile.am.

sorced-jim commented 12 years ago

Unfortunately cunit on OSX requires ncurses. http://stackoverflow.com/questions/2529963/symbol-not-found-cunit-on-snow-leopard

Why do you want to get rid of pkg-config?

On Wed, Feb 8, 2012 at 6:15 AM, Tatsuhiro Tsujikawa < reply@reply.github.com

wrote:

Thank you. I merged on_stream_close callback bug fix. For pkg-config thing, I added cunit and openssl check in configure.ac and substitute variable _LIBS and _CLFAGS in {tests/examples}/Makefile.am.

I think we can get rid of -lncurses in tests/Makefile.am. CUnit can be built without it and we don't use curses interface. If you agree, I'll remove it from tests/Makefile.am.

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3868111

Jim https://twitter.com/#!/sorced_eng

sorced-jim commented 12 years ago

For example. I have openssl 1.0.1beta2 (configure needs to check for >= 1.0.1) installed in a non-standard place. So configure now picks up 1.0.1 since it uses pkg-config. However, building doesn't pick up my headers since pkg-config is not used in the Makefile.

On Wed, Feb 8, 2012 at 10:44 AM, James Morrison jim@sorced.com wrote:

Unfortunately cunit on OSX requires ncurses.

http://stackoverflow.com/questions/2529963/symbol-not-found-cunit-on-snow-leopard

Why do you want to get rid of pkg-config?

On Wed, Feb 8, 2012 at 6:15 AM, Tatsuhiro Tsujikawa < reply@reply.github.com

wrote:

Thank you. I merged on_stream_close callback bug fix. For pkg-config thing, I added cunit and openssl check in configure.acand substitute variable _LIBS and _CLFAGS in {tests/examples}/Makefile.am.

I think we can get rid of -lncurses in tests/Makefile.am. CUnit can be built without it and we don't use curses interface. If you agree, I'll remove it from tests/Makefile.am.

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3868111

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

sorced-jim commented 12 years ago

Nevermind about pkg-config. Building/running configure a couple times seems to have fixed the issue. I'll have a patch to check for epoll and only conditionally compile spdyd.

On Wed, Feb 8, 2012 at 10:56 AM, James Morrison jim@sorced.com wrote:

For example. I have openssl 1.0.1beta2 (configure needs to check for >= 1.0.1) installed in a non-standard place. So configure now picks up 1.0.1 since it uses pkg-config. However, building doesn't pick up my headers since pkg-config is not used in the Makefile.

On Wed, Feb 8, 2012 at 10:44 AM, James Morrison jim@sorced.com wrote:

Unfortunately cunit on OSX requires ncurses.

http://stackoverflow.com/questions/2529963/symbol-not-found-cunit-on-snow-leopard

Why do you want to get rid of pkg-config?

On Wed, Feb 8, 2012 at 6:15 AM, Tatsuhiro Tsujikawa < reply@reply.github.com

wrote:

Thank you. I merged on_stream_close callback bug fix. For pkg-config thing, I added cunit and openssl check in configure.acand substitute variable _LIBS and _CLFAGS in {tests/examples}/Makefile.am.

I think we can get rid of -lncurses in tests/Makefile.am. CUnit can be built without it and we don't use curses interface. If you agree, I'll remove it from tests/Makefile.am.

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3868111

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

sorced-jim commented 12 years ago

Ahh, switching to openssl >= 1.0.1 fixed my issue with building since 1.0.0 doesn't contain the NPN patches.

On Wed, Feb 8, 2012 at 11:03 AM, James Morrison jim@sorced.com wrote:

Nevermind about pkg-config. Building/running configure a couple times seems to have fixed the issue. I'll have a patch to check for epoll and only conditionally compile spdyd.

On Wed, Feb 8, 2012 at 10:56 AM, James Morrison jim@sorced.com wrote:

For example. I have openssl 1.0.1beta2 (configure needs to check for >= 1.0.1) installed in a non-standard place. So configure now picks up 1.0.1 since it uses pkg-config. However, building doesn't pick up my headers since pkg-config is not used in the Makefile.

On Wed, Feb 8, 2012 at 10:44 AM, James Morrison jim@sorced.com wrote:

Unfortunately cunit on OSX requires ncurses.

http://stackoverflow.com/questions/2529963/symbol-not-found-cunit-on-snow-leopard

Why do you want to get rid of pkg-config?

On Wed, Feb 8, 2012 at 6:15 AM, Tatsuhiro Tsujikawa < reply@reply.github.com

wrote:

Thank you. I merged on_stream_close callback bug fix. For pkg-config thing, I added cunit and openssl check in configure.acand substitute variable _LIBS and _CLFAGS in {tests/examples}/Makefile.am.

I think we can get rid of -lncurses in tests/Makefile.am. CUnit can be built without it and we don't use curses interface. If you agree, I'll remove it from tests/Makefile.am.

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3868111

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

tatsuhiro-t commented 12 years ago

2012/02/09 4:04 "sorced-jim" < reply@reply.github.com

:

Ahh, switching to openssl >= 1.0.1 fixed my issue with building since 1.0.0 doesn't contain the NPN patches.

With your new patch, I think build is ok now. I'll add a check to see cunit requires ncurses in configure.

Best regards,

Tatsuhiro Tsujikawa

On Wed, Feb 8, 2012 at 11:03 AM, James Morrison jim@sorced.com wrote:

Nevermind about pkg-config. Building/running configure a couple times seems to have fixed the issue. I'll have a patch to check for epoll and only conditionally compile spdyd.

On Wed, Feb 8, 2012 at 10:56 AM, James Morrison jim@sorced.com wrote:

For example. I have openssl 1.0.1beta2 (configure needs to check for

1.0.1) installed in a non-standard place. So configure now picks up 1.0.1 since it uses pkg-config. However, building doesn't pick up my headers since pkg-config is not used in the Makefile.

On Wed, Feb 8, 2012 at 10:44 AM, James Morrison jim@sorced.com wrote:

Unfortunately cunit on OSX requires ncurses.

http://stackoverflow.com/questions/2529963/symbol-not-found-cunit-on-snow-leopard

Why do you want to get rid of pkg-config?

On Wed, Feb 8, 2012 at 6:15 AM, Tatsuhiro Tsujikawa < reply@reply.github.com

wrote:

Thank you. I merged on_stream_close callback bug fix. For pkg-config thing, I added cunit and openssl check in configure.acand substitute variable _LIBS and _CLFAGS in {tests/examples}/Makefile.am.

I think we can get rid of -lncurses in tests/Makefile.am. CUnit can be built without it and we don't use curses interface. If you agree, I'll remove it from tests/Makefile.am.

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3868111

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3873705

sorced-jim commented 12 years ago

Thanks, I didn't have time to do the configure check for cunit needed curses earlier. I did try to actually build cunit and fix the cunit pkg-config file, but cunit doesn't compile on Mac OS X 10.7 :(

On Wed, Feb 8, 2012 at 5:50 PM, Tatsuhiro Tsujikawa < reply@reply.github.com

wrote:

2012/02/09 4:04 "sorced-jim" < reply@reply.github.com

:

Ahh, switching to openssl >= 1.0.1 fixed my issue with building since 1.0.0 doesn't contain the NPN patches.

With your new patch, I think build is ok now. I'll add a check to see cunit requires ncurses in configure.

Best regards,

Tatsuhiro Tsujikawa

On Wed, Feb 8, 2012 at 11:03 AM, James Morrison jim@sorced.com wrote:

Nevermind about pkg-config. Building/running configure a couple times seems to have fixed the issue. I'll have a patch to check for epoll and only conditionally compile spdyd.

On Wed, Feb 8, 2012 at 10:56 AM, James Morrison jim@sorced.com wrote:

For example. I have openssl 1.0.1beta2 (configure needs to check for

1.0.1) installed in a non-standard place. So configure now picks up 1.0.1 since it uses pkg-config. However, building doesn't pick up my headers since pkg-config is not used in the Makefile.

On Wed, Feb 8, 2012 at 10:44 AM, James Morrison jim@sorced.com wrote:

Unfortunately cunit on OSX requires ncurses.

http://stackoverflow.com/questions/2529963/symbol-not-found-cunit-on-snow-leopard

Why do you want to get rid of pkg-config?

On Wed, Feb 8, 2012 at 6:15 AM, Tatsuhiro Tsujikawa < reply@reply.github.com

wrote:

Thank you. I merged on_stream_close callback bug fix. For pkg-config thing, I added cunit and openssl check in configure.acand substitute variable _LIBS and _CLFAGS in {tests/examples}/Makefile.am.

I think we can get rid of -lncurses in tests/Makefile.am. CUnit can be built without it and we don't use curses interface. If you agree, I'll remove it from tests/Makefile.am.

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3868111

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Jim https://twitter.com/#!/sorced_eng

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3873705

Reply to this email directly or view it on GitHub: https://github.com/tatsuhiro-t/spdylay/pull/7#issuecomment-3880450

Jim https://twitter.com/#!/sorced_eng

tatsuhiro-t commented 12 years ago

Done. f1c4427