tatsuyafw / gulp-nightwatch

gulp plugin for Nightwatch.js
MIT License
30 stars 18 forks source link

Plugin stops gulp executions when tests fails #44

Closed Frankusky closed 7 years ago

Frankusky commented 7 years ago

When some test fail it wont continue with the pipe. Error message:

[10:22:26] Error in plugin 'gulp-nightwatch'
Message:
    nightwatch exited with code 1
Frankusky commented 7 years ago

Looks like the issue is in this line

https://github.com/tatsuyafw/gulp-nightwatch/blob/6971ed1f495bb1b89859ed2ffab83edc51819ce1/index.js#L39

But I dont know how to fix it :disappointed: I dont know if changing the event to end will be a good idea

Frankusky commented 7 years ago

Adding on error event will let the gulp pipe continue:

  .pipe(gulpNightwatch(nightwatchOptions))
  .on("error",function(){
    this.emit("end")
  })