search

tattersoftware / codeigniter4-assets

Asset handling for CodeIgniter 4
MIT License
50 stars 12 forks source link

fix: assets config should not be called via class #59

Closed jozefrebjak closed 1 year ago

jozefrebjak commented 1 year ago

@MGatner I had this problem for long time, I can't override Assets Config in different namespace than App for example in Modules, but it was not a big deal. Overwritten assets config was in App namespace and everything worked, but after update to CodeIgniter4 to v4.4.1 filters stop to working. This small change fixed an issue. Now it's working also with 4.4.1 as expected and I can move Assets config to my Assets module namespace.

MGatner commented 1 year ago

This change looks good but there are other updates this repo needs before it is 4.4 compatible (at least for the dev workflows). I'm traveling and not likely to get a release out so I will hold this PR for now, but thank you for sending the fix and the explanation!

MGatner commented 1 year ago

Thanks @jozefrebjak