Add test for User - Githubissues

tattersoftware / codeigniter4-files

File uploads and management, for CodeIgniter 4

MIT License

61 stars 16 forks source link

Add test for User #12

Closed samsonasik closed 3 years ago

samsonasik commented 3 years ago

@MGatner It currently got the following error:

There was 1 failure:1) UserTest::testShowsOwnFiles
Failed asserting that false is true./Users/samsonasik/www/codeigniter4-files/tests/controller/UserTest.php:19

any suggestion?

MGatner commented 3 years ago

You need to assign the file to the user. E.g. model('FileModel')->addToUser($file->id, $user->id)

See also FilesTestCase::createUserWithFiles()

samsonasik commented 3 years ago

@MGatner Thank you, it fixed now.

samsonasik commented 3 years ago

implemented:

~ UserTest.php

[x] testShowsOwnFiles
[x] testShowsOtherFiles

MGatner commented 3 years ago

Is this ready to merge? Or are you planning to add more to it?

samsonasik commented 3 years ago

it is ready, if you think it need more check, just let me know

MGatner commented 3 years ago

I think this is good for now. We will need to get into permissions but that might be its own suite.