search

tattersoftware / codeigniter4-patches

Automated project updates for CodeIgniter 4
MIT License
29 stars 8 forks source link

Suggest that shebang includes `-l` #32

Closed tangix closed 9 months ago

tangix commented 1 year ago

Without 100% understanding of any security issues, may I suggest that the patch script shebang includes the -l option? Why? To make sure the shell reads ${HOME}/.profile during startup and sets up the environment properly. For example I run all php and composer commands in docker containers and using shell aliases to define these commands. Without -l, the startup script is not read and the patch command fails with ERROR 127: Composer must be installed.

MGatner commented 1 year ago

A good suggestion. Would you like to send a PR?

MGatner commented 9 months ago

@tangix I did some mild testing and this doesn't seem to affect normal behavior. I wasn't successful with research on security implications. I assume you've been using this locally and it fixes your Docker issues? Let's try it out.