search

tattersoftware / codeigniter4-relations

Entity relationships for CodeIgniter 4
MIT License
87 stars 20 forks source link

For Windows File Name Special Character Error #3

Closed tugayilhan closed 4 years ago

tugayilhan commented 4 years ago

when i try to use on windows i got some error, windows not allow special character for filename; example schemes:develop:table_name, then i changed ':' by '-' then fixed the problem. ` \tatter\schemas\src\Archiver\Handlers\CacheHandler.php:

line 46 $this->cache->save($this->cacheKey . ':' . $table->name, $table, $this->config->ttl); to $this->cache->save($this->cacheKey . '-' . $table->name, $table, $this->config->ttl);

tatter\schemas\src\Reader\Handlers\CacheHandler.php:
line 74: $this->tables->$tableName = $this->cache->get($this->cacheKey . ':' . $tableName); to $this->tables->$tableName = $this->cache->get($this->cacheKey . '-' . $tableName);

tatter\schemas\src\Traits\CacheHandlerTrait.php:

line 31: $this->cacheKey = 'schema:' . ENVIRONMENT; to $this->cacheKey = 'schema-' . ENVIRONMENT; `

MGatner commented 4 years ago

Wow I guess I've been off Windows a long time, I didn't realize colon was restricted! I will make the change to dashes. Feel free to send over a PR sooner.

MGatner commented 4 years ago

This was fixed in Schemas: https://github.com/tattersoftware/codeigniter4-schemas/commit/381708d0f7ee8b6ef2cb02ff0a9808aa812863ef