search

tattersoftware / codeigniter4-relations

Entity relationships for CodeIgniter 4
MIT License
85 stars 20 forks source link

ModelTrait not compactable with BaseModel CI4.5 #51

Open seunex17 opened 3 months ago

seunex17 commented 3 months ago

This package does not seem to work for Codeigniter V4.5

vonboth commented 3 months ago

@MGatner Can you pls. update this package to work with CI4.5? Thank you!

seunex17 commented 3 months ago

@vonboth i already fix this and send a pull request maybe he can check. https://github.com/tattersoftware/codeigniter4-relations/pull/52

damian-romanowski commented 1 month ago

Can we get a semver release now that #52 has been merged in?

Composer is still on v2.1.1.

vonboth commented 4 weeks ago

@MGatner Can you please create a new release?

vonboth commented 2 weeks ago

@MGatner Can I support you somehow with the upgrade? What is missing?

Because you said you don't use the project any longer would you like to give it to someone else?

MGatner commented 6 days ago

I'm sorry for the delay. I went to make the release and got stuck trying to fix pipeline errors. I think the issues aren't relevant, so I'll put the question to you all who are actively using this: ignore the pipeline errors and proceed with release, or someone dig into the issues blocking the pipeline?

damian-romanowski commented 5 days ago

The issues don't seem relevant.

I've been patching my installs with sed -i 's/findAll(int $limit = 0, int $offset = 0)/findAll(int $limit = null, int $offset = 0)/g' vendor/tatter/relations/src/Traits/ModelTrait.php after composer install and all works fine on ^4.5.

vonboth commented 2 days ago

I agree with you both. It doesn't seem to be relevant. So I 'd appreciate to see a new release soon.