Fix not compatable with base model in ci 4.5

[seunex17]

After upgrade to Codeigniter version 4.5 it broken while using the ModelTrait look like Codeigniter changed thier findAll() method.

i update $limit = 0 to $limit = null

CI4 now use null as default value to limit instead of 0

[damian-romanowski]

@MGatner Can this please be merged in. Struggling with quite a few projects that require this change..

[MGatner]

Has anyone tested if this is backwards-compatible? We probably need to bump the CodeIgniter framework minimum version alongside this change.

[damian-romanowski]

Has anyone tested if this is backwards-compatible? We probably need to bump the CodeIgniter framework minimum version alongside this change.

I only encountered this after updating to v4.5.0 so yeah, I believe this should bump the min ver to ^4.5.

[maldini4869]

any updates with the pr?

[MGatner]

I don't use this library myself anymore except in locked legacy projects. Honestly the experience of working with an ORM-ish in CI4 pushed me in the opposite direction, and I now favor a very bespoke Repository approach.

I am happy to maintain this library but it's harder to do things like backwards-compatibility testing. For this PR specifically I think we need to lock the framework dependency so we don't mess up older projects. If @seunex17 is not available to do that today/tomorrow then I can handle it post-merge.

[seunex17]

Okay! @MGatner am going to address this in the next hour.

[seunex17]

@MGatner please have a look and let me know it that okay to move on.

[vonboth]

@MGatner Can you please proceed with the pull request? It is the blocker to update to CI 4.5 So if you don't want to maintain the repo either another one should take over or we need to remove it from our projects. Thanks!

[seunex17]

@vonboth he might have been busy i guess.

[MGatner]

I'll get this released when I'm desktop later. Thanks for the update!

[seunex17]

Okay cool