magicLevel issue

[GoogleCodeExporter]

I've seen in recent revision that magicLevel is added on passive skill, it is 
not required.
Also, it is not possible for enchanted skills to have a magicLevel lower than 
the initial level. 

Example: Last Judgment (id="10009"), the skill lv.8 has a magicLevel=98 and 
when enchanted to +1 it's magicLevel=90. This is wrong, it lower the land rate 
of the debuff.
it should look like this:
<table name="#magicLevel">98 98 98 98 98 99 99 99 99 99</table>

Thanks for your consideration.

Original issue reported on code.google.com by iDevH...@gmail.com on 6 May 2013 at 11:10

[GoogleCodeExporter]

Here is an example of cleanup:
* Shield Charge, corrected magicLevel of enchanted skill, cannot be lower than 
the initial skill.
* Last Judgment, idem.
* Justice Punishment, idem.
* Shield Impact, idem and removed some "fly" things (wtf was this?!).
* Shield Wave, idem has Shield Impact.
* Gust Blade, removed magicLevel when enchanted, the skill is already 99, no 
need of this.
* Chain Galaxy, corrected magicLevel of enchanted skill.
* Chain Strike, removed magicLevel when enchanted.
* Final Ultimate Defense, removed unnecessary magicLevel.
* Noble Sacrifice, removed unnecessary magicLevel (no use for buffs, damnit).
* Protection of Faith, idem...
* Spike Shield, idem.
* Ignore Death, idem.
* King of Beasts, removed elementPower in recycle enchant branche.
* Party Rescue, removed magicLevel when enchanted.
* Knight Frenzy, idem.
* Superior Aggression, removed magicLevel as well, it's 99 already, why lower 
it when enchanted. Removed isReuseDelayPermanent because it shouldn't be.
* Summon Golden Lion, removed magicLevel when enchanted.

Also removed all magicLevel of passive skills when enchanted, not needed.

A lot more cleanup could be done since it's the skills.txt in asc that control 
ReuseDelay, HitTime, MpConsume and Cooltime.

Cheers, 
Hash/Kimi (l2j xml dev since c3)

Original comment by iDevH...@gmail.com on 6 May 2013 at 9:51

Attachments:

• 10000-10099.xml

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Well, I guess no one reading that...

Original comment by iDevH...@gmail.com on 12 May 2013 at 3:16