tattle-made / Uli

Software and Resources for Mitigating Online Gender Based Violence in India
https://uli.tattle.co.in
GNU General Public License v3.0
40 stars 29 forks source link

chore: Improve UI of Add Slur form #550

Closed Snehil-Shah closed 7 months ago

Snehil-Shah commented 7 months ago

name: small patch about: Improve UI of Add Slur form labels: enhancement


Relates to #409

Describe the PR

It's a small patch that adds a border to the "What makes it problematic?" text area and restricts reszing to only vertical.

Before: At first glance itself, the cursor feels like in a odd poisiton in the text area with a lot of gap between the border below. Allowing horizontal scroll makes it messier

https://github.com/tattle-made/Uli/assets/130062020/713da799-2a92-4a27-b217-057b2da8c3ed

After:

https://github.com/tattle-made/Uli/assets/130062020/49f76c92-c583-4970-a625-e7d70fe272cb

aatmanvaidya commented 7 months ago

Hi @Snehil-Shah , thank you for enchantment, it looks good, I have tested it out locally, merging the PR

aatmanvaidya commented 7 months ago

hi @Snehil-Shah

one small update to this PR

You had made the enhancement change in the SlurCreate.jsx file, you will also have to make the same change in the SlurEdit.jsx file, as while editing the form too the enhancement should show up.

If you have the time for it, can you create a new PR with the change in the SlurEdit.jsx file

dennyabrain commented 7 months ago

@aatmanvaidya subject to Snehil's availability, if he can't get to it. I suggest we merge this PR if its not breaking the slur edit workflow. A new PR can later on be made to fix this if this is purely a UI improvement.

aatmanvaidya commented 7 months ago

@dennyabrain yes this PR is already merged, after that it struck me the same change has to be made to the other file.

Its not urgent at all, if Snehil won't be able to get to it, that's fine, I can also make this quick fix.

Snehil-Shah commented 7 months ago

@aatmanvaidya Hey, that totally slipped my mind, will make a PR by today itself👍