tatumio / tatum-js

🚀 Tatum SDK: A 💪 powerful, 🌟 feature-rich TypeScript/JavaScript 📚 library that streamlines the 🛠️ development of 🌐 blockchain applications.
https://docs.tatum.io
MIT License
362 stars 113 forks source link

transactionType(s) used in multiple places with different values #1048

Closed keip closed 6 months ago

keip commented 9 months ago

When i look up the request interface GetAddressTransactionsQuery there are these 2 values:

transactionTypes?: TransactionType[]
transactionDirection?: 'incoming' | 'outgoing'

Then in the response interface AddressTransaction there is the transactionType with the type of transactionDirection:

transactionType: 'incoming' | 'outgoing' | 'zero-transfer'

Then in the response data it's called transactionSubtype which relates to the transactionTypes from GetAddressTransactionsQuery interface.

Solution: Chamge AddressTrasaction interface to:

transactionType: TransactionType // instead of 'incoming' | 'outgoing' | 'zero-transfer'
transactionDirection: 'incoming' | 'outgoing' // instead of transactionSubtype
Hathoriel commented 9 months ago

Thank you again we will process and fix the issue.

hehe100596 commented 6 months ago

Should be resolved for now with: https://github.com/tatumio/tatum-js/issues/1047#issuecomment-2046793949