search

tatut / clj-chrome-devtools

Clojure API for controlling a Chrome DevTools remote
MIT License
130 stars 21 forks source link

Stop WebSocketClient after connection is closed #20

Closed andyhorng closed 5 years ago

andyhorng commented 5 years ago

The WebSocketClient does not stop properly when automation is closed.

aviflax commented 5 years ago

I’ve been working on this too, in a local branch. Maybe I could contribute tests to your branch… would you be interested in a PR that points to this branch in your fork?

andyhorng commented 5 years ago

@aviflax Sure! Thanks your help.

aviflax commented 5 years ago

Great. I’m at an offsite today, but I’ll try to open the PR either tonight or tomorrow (British Summer Time)

aviflax commented 5 years ago

@andyhorng please see https://github.com/andyhorng/clj-chrome-devtools/pull/1 — sorry for the delay!

aviflax commented 5 years ago

@tatut any interest?