tau-bar / pe

0 stars 0 forks source link

Long name gets truncated. #5

Open tau-bar opened 2 years ago

tau-bar commented 2 years ago

Expected:

• Expected Behaviour: I should be able to see the name of a patient with a very long name.

Actual:

• Actual Behaviour: The text gets truncated. I can't see the full name. Even at full width, there is bound to be long names which will be truncated.

• Why that severity?: Low, because it is not that often that a patient has a long name. However, I feel that it could be a medium it causes a inconvenience, eg. if want to compare medical record to name on IC, and can't do so.

Steps to reproduce:

  1. Edit the name of a user to be very long. Eg. pt edit 1 n/Muhammad Adil Bin Taher Udin Bokhtier

Screenshots

Screenshot 2021-11-12 at 4.27.36 PM.png Screenshot 2021-11-12 at 4.30.27 PM.png

nus-pe-bot commented 2 years ago

Team's Response

This is purely a cosmetics issue at the default size.

The user has three options for long names to see past the truncated:

  1. Expand our application window entirely
  2. Drag the Patient View wider.
  3. Drag the Patient Details View wider.

Default size: Screenshot 2021-11-13 at 2.36.24 PM.png

Expanded window with expanded Patient View and expanded Patient Details View: Screenshot 2021-11-13 at 2.37.02 PM.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: ### Response

I disagree.

Rationale

Even with these 2 steps proposed by the developer team, it still cannot fit a viable long name. Using a 13" MacBook Air, fullscreen, patient list expanded to the maximum (shown below in evidence section). Even if the long name could fit, suppose I wanted to refer to the patient (in the patient list) and their appointment (to see the date and time), I still cannot see the full name and see the date and time at the same time.

I would categorise this as a severity.Low bug instead of a severity.Medium. I would consider this a rare occasion, which would cause inconvenience to the user. I misclicked on the option during PE, but in my rationale written during the PE, it can be seen that I intended to choose low severity instead:

Screenshot from bug report in PE: Screenshot 2021-11-17 at 6.27.52 PM.png

It is still a bug nonetheless, should the target user want to do verification and cross-refer to the name of the patient in the IC. The staff cannot do so, as the name cannot fit inside the app. This is not a totally unviable feature, as the patient's card in the patient list can indeed expand vertically (for example when many medical histories have been added), and the developer team could have handled this issue with all the space on the left side of the patient's card in the app shown below:

image.png

Evidence

image.png