Illegal string offset for Headlines

taufik-nurrohman / parsedown-extra-plugin

Configurable Markdown to HTML converter with Parsedown Extra.

MIT License

60 stars 13 forks source link

Illegal string offset for Headlines #20

Closed jaroslavlibal closed 3 years ago

jaroslavlibal commented 3 years ago

Hello,

I am facing an issue when trying the code below:

$this->parsedown->text('# Header {.sth}');

It ends up with a warning Illegal string offset 'argument' on line 297 of the ParsedownExtraPlugin.php

296:            } else if ($Mode === 'argument') {
297:                $Element['handler']['argument'] = $Content;
298:            } else {

taufik-nurrohman commented 3 years ago

This extension was intended to be used with Parsedown Extra 0.8.0. What Parsedown Extra version are you using?

jaroslavlibal commented 3 years ago

I am using Parsedown Extra 0.8.1 as I have installed your plugin via composer.

taufik-nurrohman commented 3 years ago

See the reference issue in the last commit here.

FYI, the composer version is not created by me. So the code is already outdated. I will remove the composer.json file next time. Unless I can get the package name back from the author.

You will need to contact him to delete the composer package so that I can re-create the package later and maintaining it using my composer account.

jaroslavlibal commented 3 years ago

Thanks, I did not notice that the canonical repository URLin the packagist does not correspond to your original github repo :-(

You probably don't need to remove your composer.json as it looks correct, I'd rather try the following:

Fix the required erusev/parsedown-extra version in composer.json on 0.8.0 instead of ~0.8, which will also install 0.8.1.
Ask the @pixeline as the pacakagist package maintainer to change the canonical URL to your original repository instead of his fork and make you a maintainer or rename/delete his package.

pixeline commented 3 years ago

I just did as requested. Let me know if that works !