This is a nuanced detail that hasn't worked correctly since SV was moved to per-object.
A bit of a hard one to explain, but let's try. In osu!stable's editor, slider velocity is factored into distance spacing (so current distance spacing is distance_spacing_multiplier * slider_velocity_from_current_timing_point). Since we moved slider velocity to be attached to hit objects, in lazer it would always take the SV multiplier from the previous hitobject. In the case this was a hit circle, it would not correctly fetch the SV from the last slider.
Rather than make it use the "last slider SV" (which could lead to further complication or confusion), I've opted to remove SV from factoring into distance spacing at all. This means that a mapper may need to manually adjust their distance spacing multiplier when changing slider velocities for a longer section of the beatmap. Maybe better for higher difficulties, but worse for lower? Will be interested to hear feedback on this one.
A bit of a low-effort implementation, but I'd like to push this out and see what kind of feedback mappers have. The implementation in stable is a bit nuanced, and may be preferred in some cases and potentially not in others.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps ppy.osu.Game from 2022.1022.0 to 2022.1031.0.
Release notes
Sourced from ppy.osu.Game's releases.
... (truncated)
Commits
4213abf
Adjust testflight cleanup interval to 30 days3f17c20
Updatefastlane
and dependencies9ea2bd8
Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class93c3bc6
Merge pull request #21020 from peppy/fix-pause-button-interaction1035b5f
Fix hold to pause button not working when HUD is hidden8399261
Add failing test showing hold for menu not working when HUD is hiddenf5e1134
Apply nullability to HUD test sceneaa9604c
Merge pull request #21014 from Joehuu/fix-toolbar-clock-visual-buga753369
Reuse functionTimeAtPosition()
andPositionAtTime()
.d56786b
Fix toolbar visual bug when toggling clock displaysDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)