Closed dependabot[bot] closed 1 year ago
SampleControlPoint
stuff are now applied during the decoding stage of a beatmap. By the time LoadSample
is reached, all ISampleInfo
's taken from the original HitObject would have their properties correctly set, so we don't need to do it again.
I've tested it, and the tau slider sounds matches the osu! counterparts as expected.
Done! Lemme know if I should tag a release after the merge, since I dunno how long you'll be afk.
I'll be gone for the entire day, I'd appreciate it if you were to make the release!
Bumps ppy.osu.Game from 2023.419.0 to 2023.510.0.
Commits
2097141
Merge pull request #23453 from bdach/appease-the-ios-monstrosityc809f01
Merge pull request #23416 from bdach/automated-mod-definition-updates6604b9f
Merge pull request #23434 from peppy/tick-rate-adjust745341c
Fix iOS build workflow failingf56105d
Merge branch 'master' into tick-rate-adjuste85afeb
Merge pull request #23431 from peppy/base-s-vbdf8a78
Add the ability to adjust the beatmap tick rate in the editorca5e8b2
Add clamping toSliderMultiplier
andSliderTickRate
at parsing timed10dd6d
Merge branch 'master' into base-s-v2085833
Fix missing delegate unsubscribeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)