We were missing a rounding consideration which means that.. probably half of the scores which should have been converted were not being. Luckily this is easy to resolve and can be simply re-run on top of an existing database with no further considerations.
We originally weren't considering fixing old scores set by users in their local client, but due to a sizable number of requests we've added a migration for these.
After you run this release, all your local score will be converted to the new standardised scoring system.
Note that this is a best-effort implementation. It inserts misses in a way that gives the user the best possible combo streaks considering the only information we know (MaxCombo). So if anything, you'll have to try a tiny bit harder to beat your old scores.
But at least you CAN actually beat them now, right? :)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps ppy.osu.Game from 2023.605.0 to 2023.617.0.
Release notes
Sourced from ppy.osu.Game's releases.
... (truncated)
Commits
9b3ab2f
Apply migration to new standardised score on normal reimport too5a45476
Force migration of old-new standardised scores to run once moref428cd7
Fix old-new standardised score conversion missing some scores due to not roun...fbcb684
Fix thing1e8177f
Fix score migration not considering mod multipliersc134a13
RunupdateScore
onReset
for good measure4070894
Fix score not updating whenTrackHitEvents
is set tofalse
7dc856d
Fix weird usings3ad3636
Ensure all misses are dequeued54abe57
Add more commentingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)