In preparation for locking in better audio constants in lazer, let's fix the editor waveform looking completely misaligned.
This adds a visual-only offset to better align the editor waveform (in the timeline and on the timing screen) with osu! community expectations. With this change, visual-based timing is feasible, and assuming done correctly, should be accurate within 2 ms.
When undoing, selection would be lost, and (kind of as a result) the controls on the right of the screen would enter a detached state where they don't update correctly. Quite annoying when you're making changes.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Bumps ppy.osu.Game from 2023.1008.0 to 2023.1229.0.
Release notes
Sourced from ppy.osu.Game's releases.
... (truncated)
Commits
8e3fe09
Merge pull request #26169 from bdach/universal-offset-from-session-plays1de3e37
Merge pull request #26187 from peppy/dialog-overlay-design-update93c7ebd
Remove unused using6d12451
Fix test failures due to player bailing early after failing to load beatmap619b0cc
Fix code quality inspection6718de0
Suggest audio adjust after one playe6f1d7d
MoveSessionAverageHitErrorTracker
to more general namespace24a80da
Merge branch 'master' into universal-offset-from-session-playsbb07378
Fix test failing due to querying button position during transforme027992
Merge pull request #26189 from peppy/fix-escape-key-spectator-failDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show