Freemarker template error on saving Associated Parties' page with a role

taupilu / gbif-providertoolkit

Automatically exported from code.google.com/p/gbif-providertoolkit

0 stars 1 forks source link

Freemarker template error on saving Associated Parties' page with a role #537

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What version of the provider software are you using? 

Version 2.0RC2-r2650

Which OS?

Tried on both Mac OS X and Windows XP

To Reproduce?

Go to Associated Parties page, click add, drop down a role such as programmer, 
and save the form. 

Other information

Error message cut and paste into file (attached freemarker-error)

The eml does not get filled in properly either. Notice in the attached 
screenshot of the eml the other fields of the associatedParty get filled in, 
but not the role.

Original issue reported on code.google.com by kyle.br...@gmail.com on 20 Dec 2010 at 4:41

Attachments:

[Picture 18.png](https://storage.googleapis.com/google-code-attachments/gbif-providertoolkit/issue-537/comment-0/Picture 18.png)
[Picture 19.png](https://storage.googleapis.com/google-code-attachments/gbif-providertoolkit/issue-537/comment-0/Picture 19.png)
freemarker-error

GoogleCodeExporter commented 9 years ago

Original comment by htobon on 20 Dec 2010 at 6:26

Changed state: Accepted
Added labels: Milestone-Release2.0RC3, Priority-Critical

GoogleCodeExporter commented 9 years ago

I want to take this opportunity to say that the Role enum should not exist in 
the dwrca-reader project, since roles are getting from a vocabulary:
http://rs.gbif.org/vocabulary/gbif/agent_role.xml

Agent.role should be String type, not Role type.

Original comment by htobon on 20 Dec 2010 at 8:26

GoogleCodeExporter commented 9 years ago

Tim wrote:

-----
I think the EML schema is the thing that would decide this.  If it is
controlled to a vocabulary in the EML schema, then it would translate
into an enum, but if it is string type or extensible, and we use the
vocabulary, then a String in the DwC-A reader project and controlled
with a vocabulary in the IPT makes good sense to me.

If I am correct, role looks like:
<xs:element name='role' type='xs:string'>
<xs:annotation>
<xs:documentation>Use this field to describe the role the party played
with respect to the resource. Some potential roles include technician,
reviewer, principal investigator, and many others.</xs:documentation>
</xs:annotation>
</xs:element>

Which suggests it should be a String in the dwc reader project and
controlled in the IPT.
-----

working on it!

Original comment by htobon on 21 Dec 2010 at 3:45

Changed state: Started

GoogleCodeExporter commented 9 years ago

Issue 539 has been merged into this issue.

Original comment by htobon on 21 Dec 2010 at 4:02

GoogleCodeExporter commented 9 years ago

fixed. r2727.

Major changes were done in the dwca-reader project.

Role type is now String:
http://code.google.com/p/darwincore/source/detail?r=1238

Original comment by htobon on 22 Dec 2010 at 2:10

Changed state: Fixed