search

tauri-apps / global-hotkey

Global hotkeys for Desktop Applications.
Apache License 2.0
157 stars 18 forks source link

enhance: pack mods & key into a u32 as id instead of hashing #104

Closed mixy1 closed 2 months ago

mixy1 commented 2 months ago

Change mentioned in #101.

mixy1 commented 2 months ago

Yeah seems more reasonable to use 16 bits here for each value.

Amended as requested, interesting note, I found a small discrepancy on the rust docs as well in the process: https://doc.rust-lang.org/reference/attributes/type_system.html. (Code is non_exhaustive, yet this runs perfectly well, I've opened a pr for that too)

mixy1 commented 2 months ago

Should be fine now. Thanks!