search

tauri-apps / tauri-action

Build your Web application as a Tauri binary for macOS, Linux and Windows
https://tauri.app
MIT License
782 stars 134 forks source link

latest.json file is not generated if productName contains spaces #843

Closed killerDJO closed 3 days ago

killerDJO commented 3 days ago

Steps to reproduce:

  1. Specify "productName": "With spaces" in tauri.conf.json
  2. Run github action
  3. latest.json is not uploaded, warning is printed into the log: Asset not found for the updater JSON. Skipping upload...

This seems to be a regression in a recent PR #766. In scope of it, a new approach has been introduced to detect zip file based on a signature file name: https://github.com/tauri-apps/tauri-action/pull/766/files#diff-aa2bda70857754a372eebc7152d28dbd36dba171538840d29aa7cbfa024ace09R131 However, when generating a basename normalization is not applied (spaces and other special symbols are not replaced with dots). Bacause of this, asset is not found and warning is printed.