tauri-apps / tauri-action

Build your Web application as a Tauri binary for macOS, Linux and Windows
https://tauri.app
MIT License
782 stars 134 forks source link

fix: updater file name with spaces and v2 sig files #845

Closed Legend-Master closed 3 days ago

Legend-Master commented 3 days ago

Fixes #843

Legend-Master commented 3 days ago

I don't know how I gonna test this to be honest 😖

FabianLars commented 3 days ago

we can merge this (after ci is happy) and see how the ci run on the dev branch behaves. Or if you enable ci in your fork it should also upload everything to a draft release there.

FabianLars commented 3 days ago

Or maybe not quite. Just noticed that it skips the upload on the dev branch...

Legend-Master commented 3 days ago

I'll try to run it in my fork, at the mean time, do you know what is our updater public key? Seems like there's private key set in the actions, but no public key's found

FabianLars commented 3 days ago

https://github.com/tauri-apps/tauri-action/blob/dev/.github/fixtures/example-with-tauri-v1/src-tauri/tauri.conf.json#L41

Legend-Master commented 3 days ago

Hmm, still doesn't work yet

image

https://github.com/Legend-Master/tauri-action-test/actions/runs/9757232213/job/26929173063

FabianLars commented 3 days ago

Ah that looks like my mistake, try adding this: https://github.com/tauri-apps/tauri-action/commit/f8044a1d9fa468d71dd285d9f17b467dc8c9b334#diff-eab77d5479dfaa2e1e42c5a470ba2543fd78189b8a71e9de66c2f0b1ba74cb2fR46

<space>( will get converted to . by github but our logic converts it to ..

Legend-Master commented 3 days ago

Looking at https://github.com/Legend-Master/tauri-action-test/releases/tag/3 signature files seem missing, not sure if it's related to ./.. to be honest

FabianLars commented 3 days ago

Yeah, the looking for artifcats log is also wrong, only checking for v1 sigs

Legend-Master commented 3 days ago

Trying it on https://github.com/Legend-Master/tauri-action-test/actions/runs/9757784582, upload sig files seem to work now, but not getting the asset for updater json

Legend-Master commented 3 days ago

should be good to go now

https://github.com/Legend-Master/tauri-action-test/actions/runs/9758129429 https://github.com/Legend-Master/tauri-action-test/releases/tag/7