search

tauri-apps / tauri-action

Build your Web application as a Tauri binary for macOS, Linux and Windows
https://tauri.app
MIT License
939 stars 153 forks source link

Signature verification fails when updating application build with v0.5.6 to one built with v0.5.9 #852

Closed dwilkolek closed 4 months ago

dwilkolek commented 4 months ago

I have application built with action v0.5.6. Today I released new version of my app that used v0.5.9. Old version of my application cannot verify signature of new one. When I build application with v0.5.6 it seems to work.

Related repository: https://github.com/dwilkolek/wombat

FabianLars commented 4 months ago

The action does not generate nor touch the signatures, that's all tauri and tauri's cli. The only thing that could go wrong is that it writes the wrong .sig files into latest.json but that didn't seem to be the case either (only checked .msi before you removed the release).

I'll wait for your current CI run to complete before looking into it again, just wanted to clear that part up already.

dwilkolek commented 4 months ago

I've published prerelease that used v0. I've experienced error on mac os. I'll double check on windows

dwilkolek commented 4 months ago

Windows machine updated without any issues. Looks like macos is affected.

dwilkolek commented 4 months ago

Looks like something went wrong with @tauri-apps/cli update for macos from 1.5.13 to 1.5.14. Rollback to 1.5.13 fixed the issue. Updating to 1.6.0 also fixed the issue.

Thanks for the insights. Not sure If I should report this issue at https://github.com/tauri-apps/tauri . Looks like any other version is fixing this. If I read releases correctly the only change that happen in 1.5.14 was this PR and it doesn't seem related.

FabianLars commented 4 months ago

tbh no need to report an issue over there. This seems more like a fluke of some kind and we generally don't backport bugfixes from one 1.x release to another, so if 1.6.0 works that's good enough - also, no idea what we'd have to backport, as you said, there were no related changes (and also, it was just your app so there must be some condition we're not seeing here)