search

tauri-apps / tauri-vscode

Visual Studio Code Extension for Tauri apps development
https://marketplace.visualstudio.com/items?itemName=tauri-apps.tauri-vscode
Apache License 2.0
468 stars 28 forks source link

add support for pnpm #116

Closed FabianLars closed 2 years ago

FabianLars commented 2 years ago

Why didn't that run fail in the other PR too lol

FabianLars commented 2 years ago

tauri init will fail for npm and pnpm, because we don't add a script in package.json for it. it would work with pnpm if we remove the "run" from pnpm run tauri init, but then we'd still have npm, so adding a script is the way to go here. Probably will do this tomorrow tho.

lucasfernog commented 2 years ago

Change file here is wrong. Must use " instead of ' on the package name.

FabianLars commented 2 years ago

vs code's autoformat-on-save is not my friend today...

FabianLars commented 2 years ago

@lucasfernog should i split it into 2 change files? because the changes are somewhat unrelated to each other. Btw, no idea why covector and the "Files changed"-tab are still crying about the changefile :/

lucasfernog commented 2 years ago

Github somehow thinks your change file is a binary file. Maybe delete that one and recreate lol

lucasfernog commented 2 years ago

And yeah I'd split into two change files.

lucasfernog commented 2 years ago

Finally lol