tauri-apps / tauri-vscode

Visual Studio Code Extension for Tauri apps development
https://marketplace.visualstudio.com/items?itemName=tauri-apps.tauri-vscode
Apache License 2.0
460 stars 28 forks source link

feat: provide schema for config based on tauri-build version #162

Closed amrbashir closed 1 year ago

amrbashir commented 2 years ago

This PR also includes:

FabianLars commented 1 year ago

The problem here is that the cli doesn't really care about the config anymore, it's all handled by tauri-build now and the cli only forwards configs added via the --config flag. In other words, if the user updates the cli or tauri-build without updating the other one it will pull the wrong schema file.

Aaand in a new CTA project i get this error: Unable to load schema from 'tauri://schemas/config.json': cannot open tauri://schemas/config.json. Detail: Unable to resolve resource tauri://schemas/config.json. (768)

amrbashir commented 1 year ago

The problem here is that the cli doesn't really care about the config anymore, it's all handled by tauri-build now and the cli only forwards configs added via the --config flag. In other words, if the user updates the cli or tauri-build without updating the other one it will pull the wrong schema file.

So I should check tauri-build version? cause that would be easier.

Aaand in a new CTA project i get this error: Unable to load schema from 'tauri://schemas/config.json': cannot open tauri://schemas/config.json. Detail: Unable to resolve resource tauri://schemas/config.json. (768)

I just realized I have most of the code for this PR commented out LOL plus the fallback to latest version won't work until tauri's new release.

FabianLars commented 1 year ago

So I should check tauri-build version? cause that would be easier.

As i understand it, yes

amrbashir commented 1 year ago

Thanks, merging...