tauri-apps / tauri

Build smaller, faster, and more secure desktop applications with a web frontend.
https://tauri.app
Apache License 2.0
82.08k stars 2.47k forks source link

[bug] DMG is not notarized #7533

Open Ruben-Kruepper opened 1 year ago

Ruben-Kruepper commented 1 year ago

Describe the bug

Tauri's build process automatically notarizes the .app bundle, but does not notarize the .dmg. This doesn't seem to be in the spirit of the framework.

Reproduction

Can't reproduce without a bunch of apple-specific secrets...

Expected behavior

Since notarizing the dmg will automatically notarize the app, I would expect/recommend:

  1. Sign app
  2. Make dmg
  3. Notarize dmg
  4. Staple dmg and app

This is also how other cross-platform application builders I've tried handle things on Mac.

Platform and versions

[✔] Environment
    - OS: Mac OS 13.5.0 X64
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.71.0 (8ede3aae2 2023-07-12)
    ✔ Cargo: 1.71.0 (cfd3bbd8f 2023-06-08)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (environment override by RUSTUP_TOOLCHAIN)
    - node: 20.5.0
    - pnpm: 8.6.10
    - npm: 9.8.0

Stack trace

No response

Additional context

No response

Ruben-Kruepper commented 1 year ago

I'd be more than happy PR this myself, if this is desired. 😁

JoelTankard commented 9 months ago

I have the same issue. Any updates on this?