search

tauri-apps / winres

Create and set windows icons and metadata for executables with a rust build script
MIT License
11 stars 6 forks source link

update toml to 0.8 #13

Open hjmallon opened 10 months ago

hjmallon commented 10 months ago

repo builds both toml 0.7 and 0.8, this means it only needs 0.8

FabianLars commented 10 months ago

Thanks for contributing! :)

This is actually intentional because 0.8 is incompatible with tauri's msrv and i didn't want to maintain 2 versions of winres (one for v1, one for v2). That said, there are only one or two issues we have to triage that may need changes in winres and then we can merge this. I will keep this PR open until then.

hjmallon commented 10 months ago

Oh right! embed-resource seems to pull toml 0.8 now (with 2.4) so does that still work? Or is cargo clever enough not to pull toml embed-resource 2.4?

FabianLars commented 10 months ago

If you run cargo update, or don't have a lockfile, it's unfortunetly not smart enough. But you can run cargo update -p rust-embed --precise 2.3.0 to downgrade it again.

If you wanna see something (not) fun: https://github.com/tauri-apps/tauri/blob/1.x/.github/workflows/test-core.yml#L87 (because committing the lockfile would be too easy...)