Open renovate[bot] opened 2 years ago
What is an issue on upgrading gtk
crate to v0.18? Today I tried to upgrade rfd
to the latest but I couldn't do it due to the incompatibility of the crate (wry requested v0.16 and rfd requested v0.18). And v0.16 was released almost one year ago so it looks outdated.
Hey sorry I planned to update the version this month but my framework laptop was broken. I'm reaching to one of working group member to update all the dependencies. There are a few gtk crates need to update their gir and gtk version first:
tao
and wry
accordingly.While attempting to upgrade gtk
version for javascriptcore-rs
, seems like gtk
v0.18 requires the crate cfg-expr
v0.15.5 which requires rustc version to be 1.70.0 or newer.
@amrbashir , @FabianLars , is it okay to bump our Rust version for this?
That's indeed quite steep and also the reason why we're always so slow to upgrade the gtk crates. The last times they also updated their msrv to the latest rust version available at that point :/
Anyway, we didn't really talk about the new msrv policy in v2 yet but i still believe we'll go with something like the last 3 versions / the last 6 months (same thing with current release schedule). This would mean gtk 0.18 would have to wait until December though. We could make an exception for tauri alpha&beta and apply the msrv policy only the to then stable release 🤔
I guess it's time for a proper msrv policy talk/decision including crates like webkitgtk-rs that are also used in the rust ecosystem and not just us. Edit: And with the last point updating the msrv of these crates would have been fine if webkitgtk would still be 0.x since we could just stick to an older version in wry, now i have no idea how to handle gtk updates as a whole since they are part of the public api (re-export of glib & gio) which means updating them would be a breaking change.
@FabianLars Waiting until December is too long. Do we force MSRV on alpha at the moment? If not, I think we could start updating it.
Thank you for the answer to my question. I understood that gtk-rs is aggressive on updating MSRV and it is hard to handle. And I appreciate the work to keep dependencies and MSRV by tauri developers. I'll try to keep my dependencies to be compatible with current gtk-rs crate which wry depends on.
@ FabianLars Waiting until December is too long. Do we force MSRV on alpha at the moment? If not, I think we could start updating it.
Well, we've never explicitly talked about it. So far we were still really hesitant to raise the msrv but still did it a few times. But like I said, we should have a dedicated msrv policy discussion asap!
As an interim solution i personally think it's okay to raise the msrv to whatever in the alpha versions but it could easily backfire if the policy discussion ends up deciding on something longer than "last 3 releases". We can of course also just not update webkitgtk etc in tauri and/or wry if needed, so that at other crate consumers can upgrade gtk.
Looks like gtk3 won't bump any version any time soon: https://gtk-rs.org/blog/2023/08/28/new-release.html I would say it's safe to update then. At the meantime, I'll discuss with other member about our MSRV policy.
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
Other Branches
These updates are pending. To force PRs open, click the checkbox below.
Open
These updates have all been created already. Click a checkbox below to force a retry/rebase of any.
Detected dependencies
cargo
github-actions