search

taurus-org / taurus

Moved to https://gitlab.com/taurus-org/taurus
http://taurus-scada.org
43 stars 46 forks source link

Do not force Qt theme on linux by default #1012

Closed cpascual closed 4 years ago

cpascual commented 4 years ago

The value of QT_THEME_FORCE_ON_LINUX is set to True by default in tauruscustomsettings.py, which is inconsistent with what is documented in that same module. Set it to False by default.

reszelaz commented 4 years ago

I have tested it quite a lot on the Debian Buster using this branch while trying ICALEPCS training materials (50 % done). And everything looks pretty ok. Some minor comments:

I see that we lost the "Add to favourites" icon in the macroexecutor.

Also I see that one of the icon, the one which is showed in the KDE menu -> Applications -> System appears in many places, at least:

reszelaz commented 4 years ago

I've completed all tests. With this change https://github.com/sardana-org/sardana/pull/1208 the issue of the favourites icon get solved. Regarding the TaurusDbTreeView widget, after talking with @cpascual, we could avoid using the theme icon and fix a more meaningful icon. I'm merging.