search

taurus-org / taurus

Moved to https://gitlab.com/taurus-org/taurus
http://taurus-scada.org
43 stars 46 forks source link

Don't store classid config TaurusValue unless it is a string #1063

Closed AlejandroAMarin closed 4 years ago

AlejandroAMarin commented 4 years ago

TaurusValue refuses to store configs that have items without classID. This PR modifies the code to save those items leaving a debug message that tells the classID wasn't stored. This PR fixes #840 which was actually a taurus issue, not a Sardana issue as indicated. So also fixes https://github.com/sardana-org/sardana/issues/1164

cpascual commented 4 years ago

After some discussion with @ByRellex and @reszelaz , we concluded that while this approach fixes some cases, it introduces a potential issue when changing the a TaurusValue subwidget class at runtime if classid property is not available.

A better approach is to support (de)serialization of classid in TaurusValue.createConfig and TaurusValue.applyConfig , so I am rejecting this PR in favour of #1066