search

taurus-org / taurus

Moved to https://gitlab.com/taurus-org/taurus
http://taurus-scada.org
43 stars 46 forks source link

Allow to customize Worker for ThreadPool #1081

Closed reszelaz closed 4 years ago

reszelaz commented 4 years ago

Tango is not thread safe when using threading.Thread. One must use omni threads instead. This was confirmed for parallel event subscriptions in https://github.com/tango-controls/pytango/issues/307.

For example, in the case of Sardana, the custom Worker will be protected by the EnsureOmniThread context manager intoroduced in https://github.com/tango-controls/pytango/pull/327.

reszelaz commented 4 years ago

py37-qt5 travis-ci job has problem, I will re-run it to see if it is reproducible:

ERROR: InvocationError for command /home/travis/build/taurus-org/taurus/.tox/py37-qt5/bin/python -m pytest lib/taurus --show-capture=no (exited with code -11 (SIGSEGV)) (exited with code -11)
___________________________________ summary ____________________________________
ERROR:   py37-qt5: commands failed
The command "tox" exited with 1.
Done. Your build exited with 1.
reszelaz commented 4 years ago

Now I see that fails py37-ps2:

ERROR: InvocationError for command /home/travis/build/taurus-org/taurus/.tox/py37-ps2/bin/python -m pytest lib/taurus --show-capture=no (exited with code -11 (SIGSEGV)) (exited with code -11)
___________________________________ summary ____________________________________
ERROR:   py37-ps2: commands failed

Should we merge it anywa?

cpascual commented 4 years ago

Now I see that fails py37-ps2

It was an unrelated "spurious" failure of the type we are seeing quite often. I think that they may be related to https://github.com/tango-controls/pytango/issues/292 or something similar.

Anyway, after several re-runs, it passed, so I am merging.