search

taurus-org / taurus

Moved to https://gitlab.com/taurus-org/taurus
http://taurus-scada.org
43 stars 46 forks source link

Workaround for bug #1077 #1082

Closed cpascual closed 4 years ago

cpascual commented 4 years ago

This PR fixes the exception reported in #1077: the Taurus JDraw viewer gets an exception if JDBar item is used in the jdw file because TaurusJDrawGraphicsFactory does not support it. Work around this by implementing a dummy support for JDBar.

Note that this is not proper support, but just a workaround to allow parsing (a filled JDRectangle is displayed instead of a bar).

cpascual commented 4 years ago

The py27qt4 CI test is faling systematically in travis, even when all the tests are reported passed:

py27-qt4 run-test: commands[0] | python -m pytest lib/taurus --show-capture=no

============================= test session starts ==============================
platform linux2 -- Python 2.7.15, pytest-4.6.4, py-1.8.1, pluggy-0.12.0
cachedir: .tox/py27-qt4/.pytest_cache
rootdir: /home/travis/build/taurus-org/taurus
plugins: flaky-3.6.1, xvfb-1.2.0
collected 639 items
(...)
======= 633 passed, 5 skipped, 1 xfailed, 21 warnings in 144.32 seconds ========

ERROR: InvocationError for command /home/travis/build/taurus-org/taurus/.tox/py27-qt4/bin/python -m pytest lib/taurus --show-capture=no (exited with code 1)

I ran the same tox command in my machine and I got the same output but with exit status of 0 (ok).

If this happens for other PRs, it should be investigated, but for this PR I propose to merge it anyway

@reszelaz : if you agree, please merge it