taurus-org / taurus

Moved to https://gitlab.com/taurus-org/taurus
http://taurus-scada.org
43 stars 46 forks source link

WIP: Delegate unsubscribe from events to Tango C++ (PyTango#292) #1091

Closed reszelaz closed 4 years ago

reszelaz commented 4 years ago

Tango C++ unsubscribe from any subscribed event in the DeviceProxy destructor. As workaround for PyTango#292 do not call unsubscribes in Taurus. Just mark the event type as unsubscribed so eventual event callbacks are ignored in push_event.

This PR is one of the options to workaround https://github.com/tango-controls/pytango/issues/292. It still does not work properly. I found the Sardana testsuite hung in the following situation" no_unsub_bt.txt and no_unsub_py-bt.txt

. I plan to push another option with delegating the unsubscribe to a worker thread.

reszelaz commented 4 years ago

The root issue was solved in tango-controls/cppTango#699. It is available starting from cppTango 9.3.4rc5. Hence I do not foresee to work anymore on this PR.